Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Demo Config, Noindex Tag When On Demo #2883

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add Demo Config, Noindex Tag When On Demo #2883

wants to merge 4 commits into from

Conversation

foglabs
Copy link
Contributor

@foglabs foglabs commented Nov 22, 2024

We want to add a noindex meta tag to aapb so that demo pages don't get indexed by search engines. But, we need to know when we're demo. So, add copy of production.rb as demo.rb and use that to render the tag or not

Dependencies:

  • openvault3_deploy #87
  • test demo deployment
  • => search works
  • => media plays
  • => new <meta> tag is present to avoid crawling

@ekemeyer ekemeyer requested a review from afred December 2, 2024 18:57
afred and others added 2 commits December 2, 2024 15:34
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred
Copy link
Contributor

afred commented Dec 3, 2024

@foglabs I can't get this to work for some reason. Using the branch from PR #89 openvault3_deploy you can set RAILS_ENV=demo on deployment and that seems to work fine. However, it doesn't seem to be making it's way into Rails.env for the conditional, but idk why.

@afred afred self-requested a review December 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants